(feature) : 정산 수동 완료 API 추가#53
Merged
Merged
Conversation
|
Warning Rate limit exceeded
You’ve run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (12)
Walkthrough이 PR은 결제 요청 존재 여부 조회와 정산 수동 완료 기능을 추가합니다. 결제 요청 조회는 settlement ID 기준 존재 여부 검사 엔드포인트를 구현하고, 정산 완료는 Settlement 엔티티에 마감일 검증과 기본값 설정을 추가한 뒤 적시 완료 시 아웃박스 이벤트를 생성합니다. Changes결제 요청 존재 여부 조회
정산 수동 완료
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
📝 테스트 커버리지 리포트입니다!
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In
`@src/main/java/com/dnd/moddo/event/application/impl/SettlementCompletionProcessor.java`:
- Around line 33-38: The current flow in SettlementCompletionProcessor.complete
creates completedAt before calling settlementUpdater.complete, which can
mis-evaluate isCompletedWithinDeadline; change the logic so the deadline check
uses the actual completed timestamp persisted by the updater — either (A) modify
settlementUpdater.complete to accept a LocalDateTime parameter and use that same
timestamp for persistence and the subsequent isCompletedWithinDeadline check, or
(B) have settlementUpdater.complete return the persisted completedAt (or re-read
the Settlement after update) and use that returned/stored timestamp for
settlement.isCompletedWithinDeadline; ensure SettlementUpdater.complete’s
signature/implementation and SettlementCompletionProcessor.complete are updated
consistently and keep the Outbox event creation
(commandOutboxEventService.create with OutboxEventType.SETTLEMENT_COMPLETED,
AggregateType.SETTLEMENT) tied to the same persisted timestamp decision.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
Run ID: e4809df9-e562-4b4b-85d1-5522cca664d5
📒 Files selected for processing (18)
src/docs/asciidoc/payment.adocsrc/docs/asciidoc/settlement.adocsrc/main/java/com/dnd/moddo/event/application/command/CommandSettlementService.javasrc/main/java/com/dnd/moddo/event/application/impl/PaymentRequestReader.javasrc/main/java/com/dnd/moddo/event/application/impl/SettlementCompletionProcessor.javasrc/main/java/com/dnd/moddo/event/application/query/QueryPaymentRequestService.javasrc/main/java/com/dnd/moddo/event/domain/settlement/Settlement.javasrc/main/java/com/dnd/moddo/event/infrastructure/PaymentRequestRepository.javasrc/main/java/com/dnd/moddo/event/presentation/PaymentRequestController.javasrc/main/java/com/dnd/moddo/event/presentation/SettlementController.javasrc/main/java/com/dnd/moddo/event/presentation/response/PaymentRequestExistenceResponse.javasrc/test/java/com/dnd/moddo/domain/paymentRequest/controller/PaymentRequestControllerTest.javasrc/test/java/com/dnd/moddo/domain/paymentRequest/service/QueryPaymentRequestServiceTest.javasrc/test/java/com/dnd/moddo/domain/paymentRequest/service/implementation/PaymentRequestReaderTest.javasrc/test/java/com/dnd/moddo/domain/settlement/controller/SettlementControllerTest.javasrc/test/java/com/dnd/moddo/domain/settlement/service/CommandSettlementServiceTest.javasrc/test/java/com/dnd/moddo/domain/settlement/service/implementation/SettlementCompletionProcessorTest.javasrc/test/java/com/dnd/moddo/domain/settlement/service/implementation/SettlementCreatorTest.java
sudhdkso
force-pushed
the
fix/payment-request-settlement-detail
branch
from
f797a33 to
3b5e50b
Compare
📝 테스트 커버리지 리포트입니다!
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#️⃣연관된 이슈
X
🔀반영 브랜치
fix/payment-request-settlement-detail -> develop
🔧변경 사항
💬리뷰 요구사항(선택)
X
체크:
Summary by CodeRabbit
릴리스 노트
새로운 기능
문서